Build #1,088

Plan branch:
Deploy OpenBoxes (Grails 3) to obdev3.pih-emr.org

Build: #1088 was successful

Job: Default Job was successful

Stages & jobs

  1. Build

Code commits

openboxes-develop

  • Evan <evanwaterman@hotmail.com>

    Evan <evanwaterman@hotmail.com> 573af8c1848b13ed7c26c8b26f96b9101c945e0a

    Show whether a bug report was sent after submitting it

  • Evan <evanwaterman@hotmail.com>

    Evan <evanwaterman@hotmail.com> 6113ef8f04d85196cd1be9d0e69579765bcf8243

    Merge branch 'develop' into bug/189-bug-report-feedback

  • awss <awss@awssalmubarak.com>

    awss <awss@awssalmubarak.com> 02164d1d7af161c232acd00f069f7ac14b3a653a m

    Use MessageLocalizer in processError

    • grails-app/controllers/org/pih/warehouse/core/ErrorsController.groovy (version 02164d1d7af161c232acd00f069f7ac14b3a653a)
    • src/test/groovy/org/pih/warehouse/core/ErrorsControllerSpec.groovy (version 02164d1d7af161c232acd00f069f7ac14b3a653a)
  • awss <awss@awssalmubarak.com>

    awss <awss@awssalmubarak.com> 769c17dca2f6f94286f474e12d4a002290d76414 m

    Use early returns in processError

    • grails-app/controllers/org/pih/warehouse/core/ErrorsController.groovy (version 769c17dca2f6f94286f474e12d4a002290d76414)
  • awss <awss@awssalmubarak.com>

    awss <awss@awssalmubarak.com> 77eabc547e8bf3db52273bd381aa221bd181e68e m

    Show whether a bug report was sent after submitting it
    processError ignored the result of sending the bug report email and
    always set a success flash message, which the React dashboard it
    redirects to never displayed. It now sets a success message only when
    the email is sent, and an error otherwise, and passes the flash to the
    dashboard as a URL parameter.

    useFlashScopeListener passed flash errors to notification() under
    `error` with a type it does not handle, so they showed as an empty
    toast. Pass the text as `message` with ERROR_OUTLINED instead.

    Fixes #189

    • grails-app/controllers/org/pih/warehouse/core/ErrorsController.groovy (version 77eabc547e8bf3db52273bd381aa221bd181e68e)
    • src/js/hooks/useFlashScopeListener.jsx (version 77eabc547e8bf3db52273bd381aa221bd181e68e)
    • src/js/tests/hooks/useFlashScopeListener.test.jsx (version 77eabc547e8bf3db52273bd381aa221bd181e68e)
    • src/test/groovy/org/pih/warehouse/core/ErrorsControllerSpec.groovy (version 77eabc547e8bf3db52273bd381aa221bd181e68e)