Build #151

Plan branch:
Deploy OpenBoxes (develop branch) to obdev2.pih-emr.org

Build: #151 was successful

Job: Default Job was successful

Stages & jobs

  1. Build

Code commits

openboxes-develop

  • jmiranda <jcm62@columbia.edu>

    jmiranda <jcm62@columbia.edu> 5989e34f0f84c153a1ec912f7e9142346e9e370e m

    WIP: Added shipment details to webhook payload; added auth headers to webhook request; enable webhooks globally or by location

    • grails-app/services/org/pih/warehouse/shipping/ShipmentService.groovy (version 5989e34f0f84c153a1ec912f7e9142346e9e370e)
  • jmiranda <jcm62@columbia.edu>

    jmiranda <jcm62@columbia.edu> 75af6bf4e8c10eddf503b84aefde1d7d5322c9e9 m

    WIP: Initial implementation of webhook event publisher

    • grails-app/services/org/pih/warehouse/shipping/ShipmentService.groovy (version 75af6bf4e8c10eddf503b84aefde1d7d5322c9e9)
  • jmiranda <jcm62@columbia.edu>

    jmiranda <jcm62@columbia.edu> a4708ac2cca706786741be5e2fedfb738b5c2a9f m

    OBPIH-5891 Cannot invoke method format on null object

    • grails-app/services/org/pih/warehouse/core/WebhookPublisherService.groovy (version a4708ac2cca706786741be5e2fedfb738b5c2a9f)
  • jmiranda <jcm62@columbia.edu>

    jmiranda <jcm62@columbia.edu> 13ff1af09d17a2f35627d8091ca6a920e239f17d m

    WIP: Initial implementation of webhook event publisher

    • grails-app/conf/Config.groovy (version 13ff1af09d17a2f35627d8091ca6a920e239f17d)
    • grails-app/services/org/pih/warehouse/core/ApiClientService.groovy (version 13ff1af09d17a2f35627d8091ca6a920e239f17d)
    • grails-app/services/org/pih/warehouse/core/WebhookPublisherService.groovy (version 13ff1af09d17a2f35627d8091ca6a920e239f17d)
    • grails-app/services/org/pih/warehouse/shipping/ShipmentService.groovy (version 13ff1af09d17a2f35627d8091ca6a920e239f17d)
  • jmiranda <jcm62@columbia.edu>

    jmiranda <jcm62@columbia.edu> 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1 m

    WIP: Added shipment details to webhook payload; added auth headers to webhook request; enable webhooks globally or by location

    • grails-app/conf/Config.groovy (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
    • grails-app/i18n/messages.properties (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
    • grails-app/services/org/pih/warehouse/core/ApiClientService.groovy (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
    • grails-app/services/org/pih/warehouse/core/WebhookPublisherService.groovy (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
    • grails-app/services/org/pih/warehouse/shipping/ShipmentService.groovy (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
    • grails-app/services/org/pih/warehouse/shipping/ShipmentStatusTransitionEventService.groovy (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
    • src/groovy/org/pih/warehouse/core/ActivityCode.groovy (version 15e6a0520252751fbe7b8b7cd0aeb45ce3da23b1)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 559ee375a62e018a059f89226e832dc8a9ba45ed m

    OBPIH-5809 Approval rollback - Approvals end to end workflow (#4318)
    * OBPIH-5809 Add translations for rollback approval

    * OBPIH-5809 Add function for getting most revent event

    * OBPIH-5809 Add rollbacking approval and checking if user should be able to rollback

    * OBPIH-5809 Fixes after review

    * OBPIH-5809 Add comment and checking user by id

    * OBPIH-5809 Fix after review

    • grails-app/controllers/org/pih/warehouse/inventory/StockMovementController.groovy (version 559ee375a62e018a059f89226e832dc8a9ba45ed)
    • grails-app/domain/org/pih/warehouse/requisition/Requisition.groovy (version 559ee375a62e018a059f89226e832dc8a9ba45ed)
    • grails-app/i18n/messages.properties (version 559ee375a62e018a059f89226e832dc8a9ba45ed)
    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version 559ee375a62e018a059f89226e832dc8a9ba45ed)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 559ee375a62e018a059f89226e832dc8a9ba45ed)
    • src/groovy/org/pih/warehouse/api/StockMovement.groovy (version 559ee375a62e018a059f89226e832dc8a9ba45ed)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 459aa9516a925cd604939de5e573580551bc9384 m

    OBPIH-5823 Add checking if requisition is electronic source type when sending fulfillment alert (#4321)

    • grails-app/services/org/pih/warehouse/report/NotificationService.groovy (version 459aa9516a925cd604939de5e573580551bc9384)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 78832ed33471ae913c823e22ed3628fc9c9463ca m

    OBPIH-5824 add a comment approvals comment (#4310)
    * OBPIH-5824 Adds comments for requests
    - adds ability to add comments to a request
    - adds ability to edit comments of a request
    - adds ability to delete comments of a request
    - adds comments tab to a request view page to view all of the comments

    * OBPIH-5824 Unauthorized actions such as edit and delete comment for users which are not senders

    * OBPIH-5824 Fixes After review
    - move some of the logic to service layer
    - separate save and update routes
    - cascade all-delete-orphan Comment on requisition

    * OBPIH-5824 Use g:selectUser instead of regular select
    do not throw validation error, instead return error bean to the model

    * OBPIH-5824 Move comment action to requisitionService

    * OBPIH-5824 Get requisition on comments actions instead of stockMovementService.getStockMovement for better perfomance

    * OBPIH-5824 Fix exisitng create update delete messages

    • grails-app/controllers/org/pih/warehouse/inventory/StockMovementController.groovy (version 78832ed33471ae913c823e22ed3628fc9c9463ca)
    • grails-app/domain/org/pih/warehouse/requisition/Requisition.groovy (version 78832ed33471ae913c823e22ed3628fc9c9463ca)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 78832ed33471ae913c823e22ed3628fc9c9463ca)
    • grails-app/views/stockMovement/_comments.gsp (version 78832ed33471ae913c823e22ed3628fc9c9463ca)
    • grails-app/views/stockMovement/addComment.gsp (version 78832ed33471ae913c823e22ed3628fc9c9463ca)
    • grails-app/views/stockMovement/show.gsp (version 78832ed33471ae913c823e22ed3628fc9c9463ca)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> b9f59ff6af3ee58c5a2943ab16cdd5e1ae028bd4 m

    OBPIH-5805 Approver cannot edit requests - Approvals end to end workflow (fix after QA) (#4320)
    * OBPIH-5805 enable editing request when it is approved

    * OBPIH-5805 Change conditions to fix editing when request is approved but, we are not requestor

    * OBPIH-5805 Add origin to condition

    * OBPIH-5805 Change comment in permission util

    * OBPIH-5805 Allow edit for users who are approvers

    • src/js/components/stock-movement-wizard/request/EditPage.jsx (version b9f59ff6af3ee58c5a2943ab16cdd5e1ae028bd4)
    • src/js/utils/permissionUtils.js (version b9f59ff6af3ee58c5a2943ab16cdd5e1ae028bd4)
  • Artur Walkowiak <awalkowiak@soldevelo.com>

    Artur Walkowiak <awalkowiak@soldevelo.com> 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be m

    OBPIH-5847 Fix poor performance on PO show page (#4266)
    * OBPIH-5847 Fix invoice items relations
    - add proper hasMany relations on OrderItem, OrderAdjustment and ShipmentItem
    - remove getInvoiceItems methods with poor performance

    * OBPIH-5847 Render tabs asynchronously on order show page

    * OBPIH-5847 Render order items derived status asynchronously

    * OBPIH-5847 Add methods in order service for getting summary and item status

    * OBPIH-5847 Fix deleting invoice items and invoices
    after recent domain changes

    • grails-app/controllers/org/pih/warehouse/api/PurchaseOrderApiController.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/controllers/org/pih/warehouse/invoice/InvoiceController.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/controllers/org/pih/warehouse/order/OrderController.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/domain/org/pih/warehouse/invoice/Invoice.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/domain/org/pih/warehouse/invoice/InvoiceItem.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/domain/org/pih/warehouse/order/Order.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/domain/org/pih/warehouse/order/OrderAdjustment.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/domain/org/pih/warehouse/order/OrderItem.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/domain/org/pih/warehouse/shipping/ShipmentItem.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/services/org/pih/warehouse/invoice/InvoiceService.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/services/org/pih/warehouse/order/OrderService.groovy (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/views/order/_itemStatus.gsp (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/views/order/_orderStatusFilters.gsp (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/views/order/_orderSummary.gsp (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/views/order/_summary.gsp (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
    • grails-app/views/order/show.gsp (version 5ab86b27b4f7c3aaa0beba833a4ac40e886a67be)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 7d5e8791c25e73f521f7724e35efd25f76ec3036 m

    OBPIH-5816 approval and reject actions on list page approvals lists pages (#4319)
    * OBPIH-5816 Return isUserRequestApprover from config endpoint

    * OBPIH-5816 Add approval actions in the request list

    * OBPIH-5816 Call status update for approved and rejected actions

    * OBPIH-5816 Fix tests

    * OBPIH-5816 use notification util function to render notifications

    * OBPIH-5816 Fix API context test

    • grails-app/controllers/org/pih/warehouse/api/ApiController.groovy (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • grails-app/domain/org/pih/warehouse/inventory/OutboundStockMovementListItem.groovy (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • grails-app/i18n/messages.properties (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • src/js/api/services/StockMovementApi.js (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • src/js/api/urls.js (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • src/js/components/stock-movement/outbound/StockMovementOutboundTable.jsx (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • src/js/hooks/list-pages/outbound/useOutboundListTableData.jsx (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • src/js/reducers/sessionReducer.jsx (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
    • test/unit/org/pih/warehouse/api/ApiControllerTests.groovy (version 7d5e8791c25e73f521f7724e35efd25f76ec3036)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 5ed3fbc5464399d7656a5e6ec7ee8831ce01faf4 m

    OBPIH-5806 Update with PENDING_APPROVAL status on approval submit and REQUESTED on reagular outbound (#4317)
    * OBPIH-5806 Update with PENDING_APPROVAL status on approval submit and REQUESTED on reagular outbound

    * OBPIH-5806 check if origin requires approval on PENDING_APPROVAL status

    * OBPIH-5806 Send propper status update based on fulfiling location supported activity on submit request

    * OBPIH-5806 Use constant status values for RequisitionStatus

    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version 5ed3fbc5464399d7656a5e6ec7ee8831ce01faf4)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 5ed3fbc5464399d7656a5e6ec7ee8831ce01faf4)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version 5ed3fbc5464399d7656a5e6ec7ee8831ce01faf4)
    • src/js/components/stock-movement-wizard/request/AddItemsPage.jsx (version 5ed3fbc5464399d7656a5e6ec7ee8831ce01faf4)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 54b97fe29deaeeb29fc2dd4584151d8816d03192 m

    OBPIH-5873 Investigate empty date approved after approval action (#4315)
    * OBPIH-5873 Make status transition synchronous and pass status as an argument

    * OBPIH-5873 Fix passing status

    • grails-app/services/org/pih/warehouse/inventory/RequisitionStatusTransitionEventService.groovy (version 54b97fe29deaeeb29fc2dd4584151d8816d03192)
    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version 54b97fe29deaeeb29fc2dd4584151d8816d03192)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 54b97fe29deaeeb29fc2dd4584151d8816d03192)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatusTransitionEvent.groovy (version 54b97fe29deaeeb29fc2dd4584151d8816d03192)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> c6d16a41c38d8b0812a98af23de80be64673ab3d m

    OBPIH-5864 Consumption report: Rounding issue on value consumed (#4312)
    * OBPIH-5864 change maxFractionDigits to 2 in value consumed in consumption report

    * OBPIH-5864 Change max fraction digits in csv file

    • grails-app/controllers/org/pih/warehouse/reporting/ConsumptionController.groovy (version c6d16a41c38d8b0812a98af23de80be64673ab3d)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> f05012d8b821d8f7db2d74e38067d0607b7ff67d m

    OBPIH-5811 Requestor dashboard statuses - Approvals statuses (#4309)
    * OBPIH-5811 Add getting request status label

    * OBPIH-5811 Change max width of status column

    * OBPIH-5811 Move function for getting label to service

    * OBPIH-5811 Refactor getting status label

    * OBPIH-5811 Change approach in displaying statuses in requestor dasboard

    * OBPIH-5811 Move mapping statuses to service and rename the function

    * OBPIH-5811 Move function for displaying status to StockMovement domain

    • src/groovy/org/pih/warehouse/api/StockMovement.groovy (version f05012d8b821d8f7db2d74e38067d0607b7ff67d)
    • src/groovy/org/pih/warehouse/inventory/StockMovementStatusCode.groovy (version f05012d8b821d8f7db2d74e38067d0607b7ff67d)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version f05012d8b821d8f7db2d74e38067d0607b7ff67d)
    • src/js/components/dashboard/StockRequestDashboard.jsx (version f05012d8b821d8f7db2d74e38067d0607b7ff67d)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 758eb1f252f4f2179cc6d0cb572f9f7caa40530d m

    OBPIH-5820 Prevent sending email notification for all approvers if none have been selected (#4314)

    • grails-app/i18n/messages.properties (version 758eb1f252f4f2179cc6d0cb572f9f7caa40530d)
    • grails-app/services/org/pih/warehouse/report/NotificationService.groovy (version 758eb1f252f4f2179cc6d0cb572f9f7caa40530d)
    • src/js/components/stock-movement-wizard/request/CreateStockMovement.jsx (version 758eb1f252f4f2179cc6d0cb572f9f7caa40530d)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 4e9b083c2e87f28fcd4edcdcc79fbcf2fc00b2c8 m

    OBPIH-5814 Fix empty approvers breaking stockmovement list (#4313)

    • src/js/components/stock-movement/outbound/StockMovementOutboundTable.jsx (version 4e9b083c2e87f28fcd4edcdcc79fbcf2fc00b2c8)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 491dd847e1bcd59f996d00719243fb526e11b02b m

    OBPIH-5805 Approver cannot edit requests - Approvals end to end workflow (#4302)
    * OBPIH-5805 Add util for checking if request can be edited

    * OBPIH-5805 Add new requisition statuses to enum in frontend part

    * OBPIH-5805 use canEditFunction in verifying requests, displaying edit button and in dropdown on stock movements list

    * OBPIH-5805 Fix after review

    * OBPIH-5805 Move some logic to function for editting without request approval

    * OBPIH-5805 Change naming from isRequestApprovalSupported to isApprovalRequired and change function name for editing request without required approval

    * OBPIH-5805 Remove one function and change ifs order

    • src/js/components/stock-movement-wizard/StockMovementVerifyRequest.jsx (version 491dd847e1bcd59f996d00719243fb526e11b02b)
    • src/js/components/stock-movement-wizard/request/EditPage.jsx (version 491dd847e1bcd59f996d00719243fb526e11b02b)
    • src/js/components/stock-movement/outbound/StockMovementOutboundTable.jsx (version 491dd847e1bcd59f996d00719243fb526e11b02b)
    • src/js/consts/requisitionStatus.js (version 491dd847e1bcd59f996d00719243fb526e11b02b)
    • src/js/utils/permissionUtils.js (version 491dd847e1bcd59f996d00719243fb526e11b02b)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 3cc823dbe95d4132efce865c7b6ff01a573ba53a m

    OBPIH-5854 New approval statuses in SM list pages - Approvals lists pages (fix after QA) (#4311)
    * OBPIH-5854 Remove statuses that are not on the filtering options

    * OBPIH-5854 Add comments for filtering stock movements

    • grails-app/services/org/pih/warehouse/inventory/OutboundStockMovementService.groovy (version 3cc823dbe95d4132efce865c7b6ff01a573ba53a)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version 3cc823dbe95d4132efce865c7b6ff01a573ba53a)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7 m

    OBPIH-5814 approvers column and filter in requests list page approvals lists pages (#4305)
    * OBPIH-5814 Return and display aprovers in a list of requests

    * OBPIH-5814 Add approver multiselect filter on request list page

    * OBPIH-5814 Filter by approvers

    * OBPIH-5814 Use existing label for Approvers

    * OBPIH-5814 Requested changes after review
    - refetch approvers list on location change
    - change variable names
    - filter out null users when resolving approver ids on backend

    * OBPIH-5814 Generate a distinct paginated list of stockMovements

    * OBPIH-5814 Remove a duplicated approvers fetch

    • grails-app/controllers/org/pih/warehouse/api/StockMovementApiController.groovy (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • grails-app/domain/org/pih/warehouse/inventory/OutboundStockMovementListItem.groovy (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • grails-app/services/org/pih/warehouse/inventory/OutboundStockMovementService.groovy (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/actions/index.js (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/actions/types.js (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/components/stock-movement/outbound/FilterFields.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/components/stock-movement/outbound/StockMovementOutboundList.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/components/stock-movement/outbound/StockMovementOutboundTable.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/hooks/list-pages/outbound/useOutboundFilters.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/hooks/list-pages/outbound/useOutboundListTableData.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/reducers/approversReducer.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
    • src/js/reducers/index.jsx (version ba5dbb70f1fd9721f00418e40a22ea2d1c07fdc7)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 7ddd1a7579e9cff60b19dc7d6d26470d955ee344 m

    OBPIH-5854 Remove Rejected status from outbound with required approval (#4308)

    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version 7ddd1a7579e9cff60b19dc7d6d26470d955ee344)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 8607cc17afdc9918970d3f8c8b0476b3d5266241 m

    OBPIH-5819 Fix displaying statuses in statuses different from approved and rejected (#4307)

    • grails-app/views/stockMovement/show.gsp (version 8607cc17afdc9918970d3f8c8b0476b3d5266241)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 0ac5ecfb5d4f746b95a893e008857fa567550380 m

    OBPIH-5806 Show approve and reject buttons only for request which require approval (#4306)

    • grails-app/views/stockMovement/show.gsp (version 0ac5ecfb5d4f746b95a893e008857fa567550380)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> ac78b1bf7d2bd5e4a596e38505ce4d9074399788 m

    OBPIH-5854 Add Rejected status and remove unnecessary statuses from list without supporting requests approval (#4304)

    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version ac78b1bf7d2bd5e4a596e38505ce4d9074399788)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113 m

    OBPIH-5822 email alert to requestor approvals email alerts (#4299)
    * OBPIH-5822 Added notificatin to requestor on request status change

    * OBPIH-5822 Add recent comment to the status update mail notification

    * OBPIH-5822 use find{true} instead of find() to get first element of a list

    * OBPIH-5822 Change requisition id to identifier of success message on approve/reject request

    • grails-app/controllers/org/pih/warehouse/inventory/StockMovementController.groovy (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
    • grails-app/domain/org/pih/warehouse/requisition/Requisition.groovy (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
    • grails-app/i18n/messages.properties (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
    • grails-app/services/org/pih/warehouse/inventory/RequisitionStatusTransitionEventService.groovy (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
    • grails-app/services/org/pih/warehouse/report/NotificationService.groovy (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
    • grails-app/views/email/_approvalsStatusChanged.gsp (version 365fc3a0ab08ed6a6ea1ebfb3f53373f4190f113)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 18088afca5f3198b4b8e58063c995406657fdcda m

    OBPIH-5854 New approval statuses in SM list pages - Approvals lists pages (#4290)
    * OBPIH-5854 Add waiting for approval and approved statuses

    * OBPIH-5854 Add translations for new statuses

    * OBPIH-5854 Add fetching all available statuses and change sending dropdown options

    * OBPIH-5854 Make status colum wider and add fetching statuses when changing location

    * OBPIH-5854 Fixes after review

    * OBPIH-5854 Change comment in RequisitionStatus

    * OBPIH-5854 Fixes after review

    * OBPIH-5854 Remove fetching all statuses and add handling them on frontend

    * OBPIH-5854 Remove variant from mapping status codes

    * OBPIH-5854 Fix rejected status

    * OBPIH-5854 Fixes after review

    * OBPIH-5854 Rename static method in RequisitionStatus

    * OBPIH-5854 Change mapping status label in OutboundStockMovementListItem

    * OBPIH-5854 Change isElectronicType to sourceType

    * OBPIH-5854 Change naming of list methods in RequisitionStatus

    • grails-app/controllers/org/pih/warehouse/api/StockMovementApiController.groovy (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • grails-app/domain/org/pih/warehouse/inventory/OutboundStockMovementListItem.groovy (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • grails-app/i18n/messages.properties (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/js/actions/index.js (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/js/components/Router.jsx (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/js/components/stock-movement/outbound/StockMovementOutboundList.jsx (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/js/components/stock-movement/outbound/StockMovementOutboundTable.jsx (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/js/hooks/list-pages/outbound/useOutboundFilters.jsx (version 18088afca5f3198b4b8e58063c995406657fdcda)
    • src/js/utils/StatusIndicator.jsx (version 18088afca5f3198b4b8e58063c995406657fdcda)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 565da4f7317fded0268f27a23f7605f8256cbd68 m

    OBPIH-5806 approval and reject action approvals end to end workflow (#4293)
    * OBPIH-5803 Change fetchMode of Requisition events to avoid LazyInitializationException in a published event

    * OBPIH-5803 Include status transition in RequisitionStatusTransitionEvent

    * OBPIH-5803 Add createdBy field for Event domain

    * OBPIH-5803 Fix assigning createdBy to an Event

    * OBPIH-5803 Fixes after review

    * OBPIH-5806 Render approve and reject buttons on request show page

    * OBPIH-5806 Implement approve and reject status changes logic

    * OBPIH-5806 Fix messages after updaing request status

    * OBPIH-5806 Render approve and reject buttons only on request with origin which supports approvals and for users that have roletype request approver

    * OBPIH-5806 Fix after rebase

    * OBPIH-5806 Render only reject, approve and rollback buttons to approver

    * OBPIH-5806 Rafactor requets state transition function
    remove catching excetion on updateStatus and let generic error handler catch it

    * OBPIH-5806 use requisition.status instead of status

    * OBPIH-5806 Fixes after review
    - refactor method names
    - refactor triggerRequisitionStatusTransition to use switch case instead of if

    * OBPIH-5806 Rename AuthTagLib method and add comment on status transition

    ---------

    Co-authored-by: kchelstowski <kchelstowski@soldevelo.com>

    • grails-app/controllers/org/pih/warehouse/inventory/StockMovementController.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/domain/org/pih/warehouse/core/User.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/domain/org/pih/warehouse/inventory/OutboundStockMovement.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/i18n/messages.properties (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/services/org/pih/warehouse/core/UserService.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/services/org/pih/warehouse/inventory/RequisitionStatusTransitionEventService.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/taglib/org/pih/warehouse/AuthTagLib.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • grails-app/views/stockMovement/show.gsp (version 565da4f7317fded0268f27a23f7605f8256cbd68)
    • src/groovy/org/pih/warehouse/api/StockMovement.groovy (version 565da4f7317fded0268f27a23f7605f8256cbd68)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> 1e6f488f6fb493b18b77df7a7a4b4d77beb0d0bd m

    OBPIH-5803 Fix displaying status on the PO shipment show page (#4301)

    • grails-app/views/returns/show.gsp (version 1e6f488f6fb493b18b77df7a7a4b4d77beb0d0bd)
    • grails-app/views/stockMovement/_summary.gsp (version 1e6f488f6fb493b18b77df7a7a4b4d77beb0d0bd)
    • grails-app/views/stockMovement/show.gsp (version 1e6f488f6fb493b18b77df7a7a4b4d77beb0d0bd)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> c2636cd7565e7fd75ecaf0ff6c4c9a8e9091dfe4 m

    OBPIH-5819 Approval audit - Approvals view pag (fixes after QA) (#4297)
    * OBPIH-5819 Add nullsafe operators to stockMovement.requisition on stock movement view page

    * OBPIH-5819 Remove ellipsis in approvers row

    • grails-app/views/stockMovement/show.gsp (version c2636cd7565e7fd75ecaf0ff6c4c9a8e9091dfe4)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> c4fcfbbd97c9039557e5433a0352e87d52122dd9 m

    OBPIH-5823 Fulfilment alert to requestor - Approvals email alerts (#4296)
    * OBPIH-5823 Add fulfilment email message

    * OBPIH-5823 Add sending email after chaning status to shipped

    * OBPIH-5823 Rebase branch, remove newStatus and fix wording

    • grails-app/i18n/messages.properties (version c4fcfbbd97c9039557e5433a0352e87d52122dd9)
    • grails-app/services/org/pih/warehouse/inventory/RequisitionStatusTransitionEventService.groovy (version c4fcfbbd97c9039557e5433a0352e87d52122dd9)
    • grails-app/services/org/pih/warehouse/report/NotificationService.groovy (version c4fcfbbd97c9039557e5433a0352e87d52122dd9)
    • grails-app/views/email/_fulfillmentAlert.gsp (version c4fcfbbd97c9039557e5433a0352e87d52122dd9)
  • Dariusz Rodzewicz <DRodzewicz@gmail.com>

    Dariusz Rodzewicz <DRodzewicz@gmail.com> 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad m

    OBPIH-5821 Move send notification logic to notificationService and add individual links for approvers to request list (#4289)
    * OBPIH-5803 Change fetchMode of Requisition events to avoid LazyInitializationException in a published event

    * OBPIH-5821 Move send notification logic to notificationService and add individual links for approvers to request list

    * OBPIH-5821 remove eager fetch on requisition events

    * OBPIH-5821 If there are not assigned approvers then notify all of them

    * OBPIH-5821 Separate and move methods to notificationService

    * OBPIH-5821 After review fixes
    - remove newState field from RequisitionStatusTransitionEvent
    - use requisition.state instead of previously used event.newState
    - reorder trigger status change and publish notification
    - rename variables from approvers to recipients

    ---------

    Co-authored-by: kchelstowski <kchelstowski@soldevelo.com>

    • grails-app/services/org/pih/warehouse/inventory/RequisitionStatusTransitionEventService.groovy (version 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad)
    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad)
    • grails-app/services/org/pih/warehouse/report/NotificationService.groovy (version 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad)
    • grails-app/views/email/_approvalsAlert.gsp (version 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatusTransitionEvent.groovy (version 08df7fe3cdc0ac35dff25e295e07fc7ad5a105ad)
  • Kacper Chełstowski <kchelstowski@soldevelo.com>

    Kacper Chełstowski <kchelstowski@soldevelo.com> 98e84c2f12146e521a8c75d36fb1bf3e57488e37 m

    OBPIH-5803 Display stockMovement status in the sm summary instead of … (#4295)
    * OBPIH-5803 Display stockMovement status in the sm summary instead of shipment status

    * OBPIH-5803 Adjust status of returns to be stockMovement.status not to differ from the status in the summary

    • grails-app/views/returns/show.gsp (version 98e84c2f12146e521a8c75d36fb1bf3e57488e37)
    • grails-app/views/stockMovement/_summary.gsp (version 98e84c2f12146e521a8c75d36fb1bf3e57488e37)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> ab616bb688f682eeb570e923838d3d49289d802f m

    OBPIH-5819 Approval audit - Approvals view page (#4292)
    * OBPIH-5819 Add row for Date Approved or Date rejected in SM view page

    * OBPIH-5819 Add rejected status code

    • grails-app/i18n/messages.properties (version ab616bb688f682eeb570e923838d3d49289d802f)
    • grails-app/views/stockMovement/show.gsp (version ab616bb688f682eeb570e923838d3d49289d802f)
    • src/groovy/org/pih/warehouse/inventory/StockMovementStatusCode.groovy (version ab616bb688f682eeb570e923838d3d49289d802f)
  • Alan Nadolny <83239466+alannadolny@users.noreply.github.com>

    Alan Nadolny <83239466+alannadolny@users.noreply.github.com> d3105950d77be01141d993567533cfc80f3face0 m

    OBPIH-5818 Approvers in request view page - Approvals view page (#4291)
    * OBPIH-5818 Add row for approvers

    * OBPIH-5818 Fix displaying approvers in a row

    * OBPIH-5818 Change warehouse.message to g.message

    * OBPIH-5818 Add conditional showing approvers row

    * OBPIH-5818 Add tooltip

    * OBPIH-5818 Remove isEmpty from checking if there are approvers added

    • grails-app/i18n/messages.properties (version d3105950d77be01141d993567533cfc80f3face0)
    • grails-app/views/stockMovement/show.gsp (version d3105950d77be01141d993567533cfc80f3face0)
  • Kacper Chełstowski <kchelstowski@soldevelo.com>

    Kacper Chełstowski <kchelstowski@soldevelo.com> de3618bafa4e53dae4199eba6f127347f50d1fc9 m

    OBPIH-5803 Add submit for approval functionality to create request workflow (#4288)
    * OBPIH-5803 Add approvalRequired transient to Location domain

    * OBPIH-5803 Change fetchMode of Requisition events to avoid LazyInitializationException in a published event

    * OBPIH-5803 Add request approval statuses to enums and add translations for them

    * OBPIH-5803 Include status transition in RequisitionStatusTransitionEvent

    * OBPIH-5803 Add publishing a status transition event while submitting a request

    * OBPIH-5803 Add transition status method in RequisitionService

    * OBPIH-5803 Change displayed status on SM view page to look for stockMovement status, not shipment status

    * OBPIH-5803 Add createdBy field for Event domain

    * OBPIH-5803 Add rejectedBy field to Requisition

    * OBPIH-5803 Display correct submit button depending on request approval activity and remove confirm submit modal

    * OBPIH-5803 Remove unnecessary oldStatus property from RequisitionStatusTransitionEvent

    * OBPIH-5803 Include new requisition statuses in the sortOrder formula

    * OBPIH-5803 Add default EventTypes for request approval workflow

    * OBPIH-5803 Fix assigning createdBy to an Event

    * OBPIH-5803 Fixes after review

    • grails-app/domain/org/pih/warehouse/core/Event.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/domain/org/pih/warehouse/core/Location.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/domain/org/pih/warehouse/requisition/Requisition.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/i18n/messages.properties (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/migrations/0.8.x/changelog-2023-09-21-1330-alter-table-requisition-add-rejectedby-field.xml (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/migrations/0.8.x/changelog-2023-09-21-1345-alter-table-event-add-createdby-field.xml (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/migrations/0.8.x/changelog-2023-09-21-1400-add-eventtypes-for-request-approval-workflow.xml (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/migrations/0.8.x/changelog.xml (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/services/org/pih/warehouse/inventory/RequisitionStatusTransitionEventService.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/services/org/pih/warehouse/inventory/StockMovementService.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/services/org/pih/warehouse/requisition/RequisitionService.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • grails-app/views/stockMovement/show.gsp (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • src/groovy/org/pih/warehouse/inventory/StockMovementStatusCode.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatus.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • src/groovy/org/pih/warehouse/requisition/RequisitionStatusTransitionEvent.groovy (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • src/js/components/stock-movement-wizard/request/AddItemsPage.jsx (version de3618bafa4e53dae4199eba6f127347f50d1fc9)
    • src/js/utils/supportedActivitiesUtils.js (version de3618bafa4e53dae4199eba6f127347f50d1fc9)