Build: #1367 was successful Changes by Evan <evanwaterman@hotmail.com>
Code commits
openboxes-develop-0.9.x
-
Evan <evanwaterman@hotmail.com> 61897ec6b9628e89e85172cd477076d48c1db310
Add unit test coverage for CycleCountService
-
Evan <evanwaterman@hotmail.com> 498879d689e0408f8340ec286f425b14048ee501 m
Merge branch 'develop' into td/cyclecountservice-specs
-
Christian Allen <christian@christianallen.com> 845fdcfb00be30572582d79bdba29812f383632c m
Adapt CycleCountServiceSpec to the mapper components on develop
- Define the SmartMapper bean the DTO conversion looks up, backed by the
real cycle count item and product mappers
- Inject it into the service under test
- Cover the new guard that refuses to start a count on a product with no stock- src/test/groovy/org/pih/warehouse/inventory/CycleCountServiceSpec.groovy (version 845fdcfb00be30572582d79bdba29812f383632c)
-
Christian Allen <christian@christianallen.com> 7b71e6af91c274c0b1c5b9f8446e5f356c2cec82 m
Merge remote-tracking branch 'origin/develop' into td/cyclecountservice-specs
-
Christian Allen <christian@christianallen.com> d6f808f3fcbc4cae07e6d378cb3a637014e90e58 m
Address review: tighten CycleCountServiceSpec assertions and fixtures
- Clear the thread-local current user after each test
- Rename the invalid-batch request test to claim only the failure
- Pin that a recount restart assigns the carried custom item
- Correct the canceled-count explanation and assert the status overwrite
- Bound the defaulted date counted by timestamps taken around the call
- Build the CSV fixture date as a calendar date
- Assert the exported Date Counted in the count form test- src/test/groovy/org/pih/warehouse/inventory/CycleCountServiceSpec.groovy (version d6f808f3fcbc4cae07e6d378cb3a637014e90e58)
-
Christian Allen <christian@christianallen.com> 8e213bacb4ab876e3b5985e2f3f2114f0d136001 m
Add unit test coverage for CycleCountService
- src/test/groovy/org/pih/warehouse/inventory/CycleCountServiceSpec.groovy (version 8e213bacb4ab876e3b5985e2f3f2114f0d136001)
